Repository navigation
perf: tablebase addto: avoid re-writing INDEXBLOCK for every added el… - #907
Merged
Merged
Conversation
…ement Previously, FORM re-wrote the ~330KiB INDEXBLOCK to the file for every single added element. For this reason, it has been extremely ill-advised to write a TableBase to, for eg, network storage. Resolve this by marking the INDEXBLOCK as dirty, using the existing flags, and write and flush to file only at the end of AddTo.
|
coverage: 65.838% (+0.1%) from 65.735% — jodavies:tablebase-write-size into form-dev:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ement
Previously, FORM re-wrote the ~330KiB INDEXBLOCK to the file for every single added element. For this reason, it has been extremely ill-advised to write a TableBase to, for eg, network storage.
Resolve this by marking the INDEXBLOCK as dirty, using the existing flags, and write and flush to file only at the end of AddTo.