Repository navigation
✏️ Fix misspelled id in password annotation example - #43
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the misspelled id
annotaiton-password->annotation-passwordinsrc/components/examples/form/Annotation.tsx. It occurs twice, in the field'saria-describedbyand in the matchingFormAnnotationid, and both change together, so the association between them is preserved and the name now matches the siblingannotation-companyexample. Nothing else references the id.No functional changes.
Left unchanged on purpose: in
src/components/examples/button/Expandable.tsxtheNavLink&:beforerule hasborder-left: 0.5rem solidwith no trailing semicolon, which folds the next line into its value, so bothborder-leftandtransitionare dropped as invalid CSS. It looks copied fromNavigationContent.tsx, where the value continues with a colour expression on the next line. Adding the semicolon would make an arrow appear next to every link in the hamburger-menu example, which it has never shown, so I've left that decision to you.