Skip to content

Lite: misc - #13449

Merged
OliverJAsh merged 5 commits into
masterfrom
push-wlkvprukpuxx
Apr 22, 2026
Merged

OliverJAsh merged 5 commits into
masterfrom
push-wlkvprukpuxx

Conversation

@OliverJAsh

@OliverJAsh OliverJAsh commented Apr 21, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 21:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b7f8dc70b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Lite workspace preview UI to reduce duplication when rendering per-file diffs across change/commit/branch previews.

Changes:

  • Removes the editable prop from Hunk, FileDiff, and preview components, simplifying call sites.
  • Introduces ChangesFileDiffList to centralize “fetch diff + render file header + render FileDiff” logic for multiple preview types.
  • Simplifies commit message body rendering in CommitPreview (with a behavioral caveat noted in review comments).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/lite/ui/src/routes/project/$id/workspace/route.tsx Extracts shared file-diff list rendering into ChangesFileDiffList and wires it into Changes/Commit/Branch previews; removes editable plumbing.
apps/lite/ui/src/routes/project/$id/workspace/Item.ts Adds missing /** @public */ annotation to ChangesSectionItem to align with other exported item types.

Copilot AI review requested due to automatic review settings April 21, 2026 21:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment on lines +489 to +497
Match.tag("Commit", ({ commitId }) =>
stackId !== undefined
? commitFileItem({
stackId,
commitId,
treeChange: change,
})
: undefined,
),

Copilot AI Apr 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangesFileDiffList accepts fileParent and stackId independently, but Commit sources require a stackId to build a commitFileItem. Consider tightening the props with a discriminated union so stackId is required when fileParent?._tag === "Commit" (or handle the missing stackId explicitly) to avoid silent behavior differences if it’s ever called with an inconsistent prop combination.

Suggested change
Match.tag("Commit", ({ commitId }) =>
stackId !== undefined
? commitFileItem({
stackId,
commitId,
treeChange: change,
})
: undefined,
),
Match.tag("Commit", ({ commitId }) => {
assert(
stackId !== undefined,
"`ChangesFileDiffList` requires `stackId` when `fileParent._tag === \"Commit\"`"
);
return commitFileItem({
stackId,
commitId,
treeChange: change,
});
}),

Copilot uses AI. Check for mistakes.
@samhh
samhh force-pushed the reuse-domain-types branch 3 times, most recently from 4a7ba68 to 5e31769 Compare April 22, 2026 08:41
Copilot AI review requested due to automatic review settings April 22, 2026 12:40
@OliverJAsh
OliverJAsh changed the base branch from reuse-domain-types to reuse-domain-types-2 April 22, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@samhh
samhh force-pushed the reuse-domain-types-2 branch from 2dc84ff to a6db527 Compare April 22, 2026 16:20
Base automatically changed from reuse-domain-types-2 to master April 22, 2026 16:23
@OliverJAsh
OliverJAsh merged commit 6bae6f5 into master Apr 22, 2026
36 checks passed
@OliverJAsh
OliverJAsh deleted the push-wlkvprukpuxx branch April 22, 2026 17:36

This branch was previously deployed

1 inactive deployment
Preview — 400367b9 Deployed Apr 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants