-
Notifications
You must be signed in to change notification settings - Fork 489
Add support for Linux Arm64 runners #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4c96123
43ae5e7
b4c390c
97b7459
a952c07
b5383aa
6441b26
0250090
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: "Linux Arm64" | ||
| description: "An end-to-end integration test running on a Linux Arm64 runner, checking that the native linux-arm64 CodeQL bundle is downloaded and can analyze interpreted and compiled code" | ||
| operatingSystems: | ||
| - os: ubuntu | ||
| runner-image: ubuntu-24.04-arm | ||
| # The native linux-arm64 CodeQL bundle is only available in recent CLI releases, so we restrict this | ||
| # check to `nightly-latest`, which is guaranteed to ship it. Older stable versions do not have an | ||
| # arm64 asset, and `prepare-test` would resolve an x64 bundle URL for them on this runner. | ||
| versions: | ||
| - nightly-latest | ||
| installGo: true | ||
| steps: | ||
| - uses: ./../action/init | ||
| with: | ||
| languages: javascript,python,go | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor and doesn't have to be addressed in this PR, but it might be good to analyse all languages that we support on arm64 (ignore if that's already what this list is) |
||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
| - name: Build Go code | ||
| run: go build main.go | ||
| - uses: ./../action/analyze | ||
| with: | ||
| upload-database: false | ||
|
redsun82 marked this conversation as resolved.
|
||
| - name: Assert databases exist | ||
| run: | | ||
| cd "$RUNNER_TEMP/codeql_databases" | ||
| for lang in javascript python go; do | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor: It would be nice if the list of languages wasn't duplicated between the |
||
| if [[ ! -d "$lang" ]]; then | ||
| echo "Did not find a database for $lang" | ||
| exit 1 | ||
| fi | ||
| done | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: "download" -> "downloads" to make the tense consistent