fix: remove unused scope input from bundled speckit workflow - #4401
Open
gyanu2507 wants to merge 1 commit into
Open
fix: remove unused scope input from bundled speckit workflow#4401gyanu2507 wants to merge 1 commit into
gyanu2507 wants to merge 1 commit into
Conversation
The Full SDD Cycle workflow prompted for full / backend-only / frontend-only, but none of the steps read inputs.scope. Every command only received inputs.spec, so the three choices behaved the same. Remove the dead input from the shipped workflow and align the docs that showed `specify workflow run speckit ... -i scope=...`. Keep scope as an example in the generic input-typing docs for authors who do wire it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scopeinput fromworkflows/speckit/workflow.ymlspecify workflow run speckit ... -i scope=...Context
The bundled Full SDD Cycle workflow declared
scopewithfull/backend-only/frontend-only, but every command step only passed{{ inputs.spec }}. Choosing a scope did nothing. The safer fix for the shipped workflow is to stop advertising the selector until something actually consumes it. Authors who want scope gating can still declare it on their own workflows (examples inworkflows/README.mdremain).Test plan
uv run pytest tests/workflows/test_bundled_speckit_workflow.pyFixes #4384
Made with Cursor