docs: resolve assess clarifications by editing artifacts in place - #4402
Open
gyanu2507 wants to merge 1 commit into
Open
docs: resolve assess clarifications by editing artifacts in place#4402gyanu2507 wants to merge 1 commit into
gyanu2507 wants to merge 1 commit into
Conversation
The assess README and decide command told people to re-run an earlier stage when decision.md said needs-clarification. That fights the sequential intake → research → define → shape → decide flow: each command normally runs once and leaves an editable Markdown file. Document direct edits and free-form agent updates as the default path, including refining decision.md itself, and keep stage re-runs as the exception for bad or discarded drafts.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate documentation inconsistencies must be resolved before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Documents in-place clarification for the sequential assess workflow rather than rerunning stages.
Changes:
- Explains editable artifact refinement.
- Updates decision-stage clarification guidance.
- Revises the assess flow diagram.
File summaries
| File | Review |
|---|---|
extensions/assess/README.md |
Flow diagram still routes clarification back to intake; use an artifact-refinement node returning to the decision. |
extensions/assess/commands/speckit.assess.decide.md |
Add decision.md to the allowed clarification artifacts. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| C -->|go| SPEC[/speckit.specify/] | ||
| C -->|kill| X[closed, recorded] | ||
| C -.->|needs-clarification: revisit the named earlier stage| A | ||
| C -.->|needs-clarification: refine the named artifact in place| A |
|
|
||
| - **Blocking questions**: [NEEDS CLARIFICATION: …] | ||
| - **Revisit stage**: intake | research | define | shape | ||
| - **Artifact to refine**: intake.md | research.md | problem.md | concept.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needs-clarificationat refining the named artifact (ordecision.md), not re-running the stage by defaultspeckit.assess.decideguidance to matchContext
[NEEDS CLARIFICATION: …]markers were easy to read as “go back and re-run intake/research/…”. The assess extension is meant to be sequential: fill gaps in the existing files, then continue. A dedicated clarify loop stays out of scope (custom extension/preset territory).Test plan
uv run pytest tests/extensions/assess/extensions/assess/README.mdandspeckit.assess.decide.mdfor consistencyFixes #4378
Made with Cursor