Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

minor fixes to requirements and to dataset paths - #1

Open
xvdp wants to merge 3 commits into
google-research:masterfrom
xvdp:master
Open

xvdp wants to merge 3 commits into
google-research:masterfrom
xvdp:master

Conversation

@xvdp

@xvdp xvdp commented May 22, 2020

Copy link
Copy Markdown

Hi, thanks for the github. I noticed a couple packages that were missing from the requirements - I installed in a blank python=3 conda environment.
Also, lsun princeton didn't respond, So i fixed that too.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@xvdp

xvdp commented May 22, 2020 via email

Copy link
Copy Markdown
Author

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@xvdp

xvdp commented May 22, 2020 via email

Copy link
Copy Markdown
Author

@david-berthelot david-berthelot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please leave tensorflow-gpu version to the latest (1.15.2).
  2. libml is not a dependency, it's part of the code base, please remove it from requirements.txt
  3. As to the lsun path, I'd rather use the official one, I contact Princeton a few days ago, they're looking why their website is not responding. Maybe you can create an issue to discuss your workaround if others face the same problem but I'd prefer the code unchanged for this.
  4. Your CLA still has problems.

@xvdp

xvdp commented May 22, 2020 via email

Copy link
Copy Markdown
Author

@singhaditya28 singhaditya28 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already Added

Comment thread requirements.txt
Pillow==5.3.0
seaborn
scipy
tensorflow-gpu==1.15.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

def _load_lsun(category):
data = {}
for subset in ('train', 'val'):
url = 'http://lsun.cs.princeton.edu/htbin/download.cgi?tag=latest&category=%s&set=%s' % (category, subset)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand its necessity.

Comment thread .gitignore
@@ -0,0 +1 @@
__pycache__/ No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already Added!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants