Repository navigation
fix(core): replace unsafe Optional.get() calls with orElseThrow - #1809
Open
Rajkumar7633 wants to merge 1 commit into
Open
Rajkumar7633 wants to merge 1 commit into
Rajkumar7633 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Replace Optional.get() calls in LLM flow request processors with orElseThrow() and meaningful error messages, so missing values surface as IllegalStateException with context instead of an opaque NoSuchElementException.
Rajkumar7633
force-pushed
the
fix/unsafe-optional-get
branch
from
November 13, 2026 21:41
7c5f3bd to
8e5e9a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces unsafe
Optional.get()calls in the LLM flow request processors withorElseThrow()and meaningful error messages. Previously, a missing value would surface as an opaqueNoSuchElementException; now it throwsIllegalStateExceptionwith context about which value was expected.This was split out of #1386 per review feedback, since it changes core behavior and is unrelated to the code assistant tutorial.
Changes
Basic.java: model name resolution now usesmap/orElseGet/orElseThrowinstead ofisPresent()/get()OutputSchema.java:outputSchema()accessed viaorElseThrowwith a descriptive messageRequestConfirmationLlmRequestProcessor.java:confirmationResultand function call IDs accessed viaorElseThrowinstead ofget()Testing
./mvnw test -pl core -Dtest='BasicTest,OutputSchemaTest,RequestConfirmationLlmRequestProcessorTest'— all 50 tests pass