Skip to content

telemetry: move internal/axattr to internal/telemetry/attr #684

Open

Description

@rakyll

`internal/axattr` names the OpenTelemetry attributes AX puts on its spans, logs, and events (`ax.task.`, and Substrate's `ate.` for actor identity). It is part of ax-server's telemetry, so it belongs next to `internal/telemetry` and `internal/telemetry/otelenv` rather than at the top of `internal/`.

Proposal: move it to `internal/telemetry/attr` (package `attr`), so call sites read `attr.TaskName` and so on.

Scope:

  • Move `internal/axattr/axattr.go` to `internal/telemetry/attr/attr.go` and rename the package.
  • Update the link in `docs/observability.md` and the `internal/axattr` line in the `AGENTS.md` layout.
  • Nothing imports `internal/axattr` today, so no Go call sites change. Worth checking whether ax-server should be using these names where it emits spans, logs, and events now.

Activity

  1. added this to the v0.4.0 milestone on Nov 21, 2026
  2. akshad-exe commented on Nov 22, 2026

    @akshad-exe

    #684 — moving internal/axattr → internal/telemetry/attr

    Branch: akshad-exe/ax → chore/move-axattr-to-telemetry-attr (commit 8462aad).

    What it does:

    • Moves internal/axattr/axattr.go to internal/telemetry/attr/attr.go, renames the package to attr. Every attribute key is unchanged; git records it as a rename.
    • Updates the AGENTS.md layout row and the docs/observability.md link.

    Nothing imports the package today, so no Go call sites change. The keys appear outside the package only in internal/telemetry/telemetry_test.go, which writes "ax.task.id" as a literal to pin the wire name, so those stay as-is.

    Verified: make verify (0 issues), go test ./..., gofmt -l.

    Note: #665 adds constants to this file and will import it; whichever lands second needs a small rebase.

    Outside PRs are limited to collaborators here, so could a collaborator open a pull request from akshad-exe:chore/move-axattr-to-telemetry-attr? Happy to rebase/split as needed.

  3. self-assigned this
    on Nov 22, 2026
  4. modified the milestones: v0.4.0, v1.0.0 on Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions