You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
telemetry: move internal/axattr to internal/telemetry/attr #684
`internal/axattr` names the OpenTelemetry attributes AX puts on its spans, logs, and events (`ax.task.`, and Substrate's `ate.` for actor identity). It is part of ax-server's telemetry, so it belongs next to `internal/telemetry` and `internal/telemetry/otelenv` rather than at the top of `internal/`.
Proposal: move it to `internal/telemetry/attr` (package `attr`), so call sites read `attr.TaskName` and so on.
Scope:
Move `internal/axattr/axattr.go` to `internal/telemetry/attr/attr.go` and rename the package.
Update the link in `docs/observability.md` and the `internal/axattr` line in the `AGENTS.md` layout.
Nothing imports `internal/axattr` today, so no Go call sites change. Worth checking whether ax-server should be using these names where it emits spans, logs, and events now.
Moves internal/axattr/axattr.go to internal/telemetry/attr/attr.go, renames the package to attr. Every attribute key is unchanged; git records it as a rename.
Updates the AGENTS.md layout row and the docs/observability.md link.
Nothing imports the package today, so no Go call sites change. The keys appear outside the package only in internal/telemetry/telemetry_test.go, which writes "ax.task.id" as a literal to pin the wire name, so those stay as-is.
Verified: make verify (0 issues), go test ./..., gofmt -l.
Note: #665 adds constants to this file and will import it; whichever lands second needs a small rebase.
Outside PRs are limited to collaborators here, so could a collaborator open a pull request from akshad-exe:chore/move-axattr-to-telemetry-attr? Happy to rebase/split as needed.
Activity
akshad-exe commentedon Nov 22, 2026
#684 — moving internal/axattr → internal/telemetry/attr
Branch:
akshad-exe/ax→chore/move-axattr-to-telemetry-attr(commit8462aad).What it does:
internal/axattr/axattr.gotointernal/telemetry/attr/attr.go, renames the package toattr. Every attribute key is unchanged; git records it as a rename.AGENTS.mdlayout row and thedocs/observability.mdlink.Nothing imports the package today, so no Go call sites change. The keys appear outside the package only in
internal/telemetry/telemetry_test.go, which writes"ax.task.id"as a literal to pin the wire name, so those stay as-is.Verified:
make verify(0 issues),go test ./...,gofmt -l.Note: #665 adds constants to this file and will import it; whichever lands second needs a small rebase.
Outside PRs are limited to collaborators here, so could a collaborator open a pull request from
akshad-exe:chore/move-axattr-to-telemetry-attr? Happy to rebase/split as needed.