Repository navigation
fix(server): ignore client-supplied uid, timestamps and status - #659
Merged
Merged
Conversation
The server assigns them on create and update, so a manifest copied from `ax get` no longer creates a resource with the same uid. The proto comments mark them as ignored on input.
mayawang
approved these changes
Nov 19, 2026
mayawang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks Yongrui! Nice catch on promote, and good to stop CreateTask trusting a client status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore the
metadata.uid, timestamps andstatusa client sends on create and update; the server assigns them (AIP-203, item 1 of #563 (comment)).CreateTaskkept them, so a manifest copied fromax getcreated a task with the source's uid, andax promoteto that target failed with "source and target must differ".uid; they now ignore the timestamps too and get anupdateTime.metadata.owneris unchanged.