Skip to content

fix(server): ignore client-supplied uid, timestamps and status - #659

Merged
yongruilin merged 1 commit into
google:mainfrom
yongruilin:ax-aip-server-assigned-fields
Nov 19, 2026
Merged

yongruilin merged 1 commit into
google:mainfrom
yongruilin:ax-aip-server-assigned-fields

Conversation

@yongruilin

Copy link
Copy Markdown
Collaborator

Ignore the metadata.uid, timestamps and status a client sends on create and update; the server assigns them (AIP-203, item 1 of #563 (comment)).

  • CreateTask kept them, so a manifest copied from ax get created a task with the source's uid, and ax promote to that target failed with "source and target must differ".
  • Workspace, Gateway and Model already ignored a client uid; they now ignore the timestamps too and get an updateTime.
  • The proto comments mark these fields as ignored on input, as Agent Substrate does; metadata.owner is unchanged.

The server assigns them on create and update, so a manifest copied from
`ax get` no longer creates a resource with the same uid. The proto
comments mark them as ignored on input.

@mayawang mayawang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yongrui! Nice catch on promote, and good to stop CreateTask trusting a client status

@yongruilin
yongruilin merged commit 2a747da into google:main Nov 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants