Repository navigation
fix(promote): handle a finished task and a workspace's setup gateway - #664
Merged
Merged
Conversation
The source refuses to suspend a task that has run to its end, so --suspend-source failed.
The target refuses a new Workspace whose setup Gateway is missing, so promote failed at the Workspace.
The Workspace of TestE2E_Promote names a Gateway for its setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to
ax promote, for cases that did not exist when it was written (#618).spec.setup.gatewayuntil workspace pre-warming was on by default (ax-server, e2e: enable workspace pre-warming by default and add shared custom-image E2E #651, hack/hero-demo: check the warm workspace snapshot in Step 2 #663), so promote had only the Task's Gateway to copy. A Workspace can now name one, and the target cannot create the Workspace without it, so promote copies it first, the same way as the Task's Gateway, when the target has to create the Workspace.--suspend-sourcefail. Such a task is no longer suspended.TestE2E_Promotenow uses a Workspace with a setup Gateway.