Skip to content

fix(promote): handle a finished task and a workspace's setup gateway - #664

Merged
yongruilin merged 3 commits into
google:mainfrom
yongruilin:ax-promote-setup-gateway
Nov 20, 2026
Merged

yongruilin merged 3 commits into
google:mainfrom
yongruilin:ax-promote-setup-gateway

Conversation

@yongruilin

Copy link
Copy Markdown
Collaborator

Two fixes to ax promote, for cases that did not exist when it was written (#618).

The source refuses to suspend a task that has run to its end, so
--suspend-source failed.
The target refuses a new Workspace whose setup Gateway is missing, so
promote failed at the Workspace.
The Workspace of TestE2E_Promote names a Gateway for its setup.

@mayawang mayawang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yongrui! Both are exactly the gaps #639 and #663 opened up

@yongruilin
yongruilin merged commit de7de90 into google:main Nov 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants