Skip to content

hack: use the ax-runner image in the local install smoke test - #682

Merged
aojea merged 1 commit into
google:mainfrom
aojea:fix-local-install-runner-rename
Nov 21, 2026
Merged

aojea merged 1 commit into
google:mainfrom
aojea:fix-local-install-runner-rename

Conversation

@aojea

@aojea aojea commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

Problem

The job Local install (ax local start) fails on main since #666 merged: https://github.com/google/ax/actions/runs/44842538569/job/136654239973

==> Building ax and the AX images into localhost:5001...
cat: /home/runner/work/ax/ax/bin/ax-task-runner.digest: No such file or directory
make: *** [Makefile:221: test-local-install] Error 1

The guide has the same command in "Using Locally Built Images" (docs/local_installer.md), so that step fails for a user too.

Cause

#677 renamed ax-task-runner to ax-runner. Since then make images pushes ax-runner and writes bin/ax-runner.digest. hack/test-local-install.sh, which #666 added, reads bin/ax-task-runner.digest.

Neither PR saw the other:

Change

  • hack/test-local-install.sh: use the ax-runner image and bin/ax-runner.digest, and clear AX_RUNNER_IMAGE (the new name of the Makefile variable).
  • docs/local_installer.md: the same name in the AX_TASK_IMAGE line of "Using Locally Built Images".
  • internal/install/cluster/kind_test.go: the new name in two sample image references. The test does not depend on the name.
  • hack/test-local-install.sh: when the script fails before ax local start creates a cluster, it no longer prints the state of a cluster. In the failed job, that part was only kubectl connection errors to localhost:8080.

Result

Check Result
make test-local-install on main at 7d3ba98 Fails with the cat error above
make test-local-install with this change Passes in 2 min 14 s; the task runs from localhost:5001/ax-runner@sha256:...
A failure before the cluster exists (a registry image that does not exist) Prints the docker error only

make verify, go build of the three binaries, and go test ./... pass.

Not run again: a failure after the cluster exists. ax local start sets the kubeconfig context that the new condition tests, so that case still prints the state of the cluster.

A merge queue (#571, #575) tests each PR on the main it merges into, and so finds this kind of break before the merge.

The local install job fails on main: hack/test-local-install.sh reads
bin/ax-task-runner.digest, and 'make images' writes bin/ax-runner.digest
since ax-task-runner was renamed to ax-runner (google#677). google#677 merged after
the last CI run of google#666, which added the script, and before google#666 merged,
so neither change saw the other.

The guide has the same command in "Using Locally Built Images", and a unit
test has the old name in two sample image references. Use the new name in
all three.

When the script fails before 'ax local start' creates a cluster, it no
longer prints the state of a cluster. There is none, and kubectl printed
only connection errors.
@aojea aojea self-assigned this Nov 21, 2026
@aojea
aojea requested a review from rakyll November 21, 2026 00:34
@aojea
aojea requested a review from mayawang November 21, 2026 00:34

@mayawang mayawang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andrew! Good catch on the #666 / #677 crossover

@aojea
aojea marked this pull request as ready for review November 21, 2026 01:15
@aojea
aojea merged commit 0b44e97 into google:main Nov 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants