Repository navigation
hack: use the ax-runner image in the local install smoke test - #682
Merged
Merged
Conversation
The local install job fails on main: hack/test-local-install.sh reads bin/ax-task-runner.digest, and 'make images' writes bin/ax-runner.digest since ax-task-runner was renamed to ax-runner (google#677). google#677 merged after the last CI run of google#666, which added the script, and before google#666 merged, so neither change saw the other. The guide has the same command in "Using Locally Built Images", and a unit test has the old name in two sample image references. Use the new name in all three. When the script fails before 'ax local start' creates a cluster, it no longer prints the state of a cluster. There is none, and kubectl printed only connection errors.
rakyll
approved these changes
Nov 21, 2026
aojea
marked this pull request as ready for review
November 21, 2026 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The job
Local install (ax local start)fails onmainsince #666 merged: https://github.com/google/ax/actions/runs/44842538569/job/136654239973The guide has the same command in "Using Locally Built Images" (
docs/local_installer.md), so that step fails for a user too.Cause
#677 renamed
ax-task-runnertoax-runner. Since thenmake imagespushesax-runnerand writesbin/ax-runner.digest.hack/test-local-install.sh, which #666 added, readsbin/ax-task-runner.digest.Neither PR saw the other:
main, so the rename could not include it.Change
hack/test-local-install.sh: use theax-runnerimage andbin/ax-runner.digest, and clearAX_RUNNER_IMAGE(the new name of the Makefile variable).docs/local_installer.md: the same name in theAX_TASK_IMAGEline of "Using Locally Built Images".internal/install/cluster/kind_test.go: the new name in two sample image references. The test does not depend on the name.hack/test-local-install.sh: when the script fails beforeax local startcreates a cluster, it no longer prints the state of a cluster. In the failed job, that part was onlykubectlconnection errors tolocalhost:8080.Result
make test-local-installonmainat 7d3ba98caterror abovemake test-local-installwith this changelocalhost:5001/ax-runner@sha256:...dockererror onlymake verify,go buildof the three binaries, andgo test ./...pass.Not run again: a failure after the cluster exists.
ax local startsets the kubeconfig context that the new condition tests, so that case still prints the state of the cluster.A merge queue (#571, #575) tests each PR on the
mainit merges into, and so finds this kind of break before the merge.