Repository navigation
Conversation
Restore the push model from 241bc4d: the reconciler builds a per-task actor template that carries the Task and Workspace as AX_TASK_YAML and AX_WORKSPACE_YAML, and ax-runner reads them at startup. Remove the pull protocol: internal/runnerhttp (:8081 and its token), internal/lifecycle, pkg/apis/runner/v1, the runner egress rule, the server task applier, and the control state in TaskRow. Keep the launcher contract (#621), the egress CA and git-askpass (#581), and spec.setup. Workspace pre-warming is dormant: Workspace spec.profile and spec.setup.gateway are rejected as unimplemented, and tasks no longer report COMPLETED or FAILED with output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the push runner from 241bc4d while keeping the later work that doesn't depend on pull. The runner contract needs a rewrite, and this gets us back to a simpler starting point.
Delivery
<task>-tmpl-<hash>over the image, the runner volume and the env). The template carries the Task and Workspace asAX_TASK_YAMLandAX_WORKSPACE_YAML, and is deleted along with the task.ax-runnerreads them at startup throughrunner.LoadSpec.Removed
internal/runnerhttp(the:8081service and its OIDC/JWT token),internal/lifecycle, andpkg/apis/runner/v1.internal/substrate/runner_egress.go,internal/server/task_applier.go,runner/pull.goandrunner/output_buffer.go.store.TaskRow, which is now{Task, Generation}.schema.sqldrops no columns, so existing databases keep the old ones.:8081port in the deploy and E2E manifests, plus the matching text inskills/substrate.Kept
spec.setup.ax-runnerrename (all: rename ax-task-runner to ax-runner #677), required images (api, server: require Task spec.profile to name an image; drop the default image #647), task: change TaskStatus.ate_actor_template to ObjectRef ate_template #642 and hack/hero-demo: check the warm workspace snapshot in Step 2 #663.What users lose
PrewarmEnabled()is false, and the server rejects Workspacespec.profileandspec.setup.gatewayas Unimplemented. Each task runsspec.setupin its own sandbox.docs/manifests.mdand the hero demo now say this.Testing
make verifygo build ./cmd/ax ./cmd/ax-server ./cmd/ax-runnergo test ./...postgres:17-alpine)make test-e2emake test-local-install#685 can be closed once this merges, since
runnerhttpis gone.