Skip to content

runner: go back to the push runner - #686

Closed
rakyll wants to merge 1 commit into
mainfrom
runner
Closed

rakyll wants to merge 1 commit into
mainfrom
runner

Conversation

@rakyll

@rakyll rakyll commented Nov 21, 2026

Copy link
Copy Markdown
Member

This PR restores the push runner from 241bc4d while keeping the later work that doesn't depend on pull. The runner contract needs a rewrite, and this gets us back to a simpler starting point.

Delivery

  • The reconciler builds a per-task actor template (<task>-tmpl-<hash> over the image, the runner volume and the env). The template carries the Task and Workspace as AX_TASK_YAML and AX_WORKSPACE_YAML, and is deleted along with the task.
  • ax-runner reads them at startup through runner.LoadSpec.
  • A gateway applies its egress rules directly to the task actor.

Removed

  • internal/runnerhttp (the :8081 service and its OIDC/JWT token), internal/lifecycle, and pkg/apis/runner/v1.
  • internal/substrate/runner_egress.go, internal/server/task_applier.go, runner/pull.go and runner/output_buffer.go.
  • The control state in store.TaskRow, which is now {Task, Generation}. schema.sql drops no columns, so existing databases keep the old ones.
  • The :8081 port in the deploy and E2E manifests, plus the matching text in skills/substrate.

Kept

What users lose

  • Workspace pre-warming is dormant. Without a setup coordinator, PrewarmEnabled() is false, and the server rejects Workspace spec.profile and spec.setup.gateway as Unimplemented. Each task runs spec.setup in its own sandbox.
  • Tasks no longer reach COMPLETED or FAILED with output.
  • docs/manifests.md and the hero demo now say this.

Testing

  • make verify
  • go build ./cmd/ax ./cmd/ax-server ./cmd/ax-runner
  • go test ./...
  • Postgres store tests (postgres:17-alpine)
  • make test-e2e
  • make test-local-install

#685 can be closed once this merges, since runnerhttp is gone.

Restore the push model from 241bc4d: the reconciler builds a per-task
actor template that carries the Task and Workspace as AX_TASK_YAML and
AX_WORKSPACE_YAML, and ax-runner reads them at startup.

Remove the pull protocol: internal/runnerhttp (:8081 and its token),
internal/lifecycle, pkg/apis/runner/v1, the runner egress rule, the
server task applier, and the control state in TaskRow. Keep the
launcher contract (#621), the egress CA and git-askpass (#581), and
spec.setup.

Workspace pre-warming is dormant: Workspace spec.profile and
spec.setup.gateway are rejected as unimplemented, and tasks no longer
report COMPLETED or FAILED with output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant