Repository navigation
Conversation
Remove six functions that no binary reaches: - metadata.Server.IsWorkspaceReady and Server.ProbeAddr. The metadata tests move into package metadata and read the probe listener's address from the Server. - substrate.NewClient. The reconciler tests and substratetest connect with NewClientWithOptions over plaintext. - substrate.ResourceLimits and its test. The controller resolves profile limits itself. - guest.Dial, a one-argument wrapper over DialTarget. - The server's storedStatus, a wrapper over store.StoredStatus, which TestStoredStatus now calls. With that wrapper gone, guest.DialTarget is renamed Dial and guest.DialTargetTLS is renamed DialTLS. skills/substrate/SKILL.md is updated to match. Updates #703
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove six functions that no binary reaches:
With that wrapper gone, guest.DialTarget is renamed Dial and guest.DialTargetTLS is renamed DialTLS. skills/substrate/SKILL.md is updated to match.
Updates #703