Skip to content

all: remove dead code and rename guest.DialTarget to Dial - #705

Open
rakyll wants to merge 1 commit into
mainfrom
dead-code
Open

rakyll wants to merge 1 commit into
mainfrom
dead-code

Conversation

@rakyll

@rakyll rakyll commented Nov 22, 2026

Copy link
Copy Markdown
Member

Remove six functions that no binary reaches:

  • metadata.Server.IsWorkspaceReady and Server.ProbeAddr. The metadata tests move into package metadata and read the probe listener's address from the Server.
  • substrate.NewClient. The reconciler tests and substratetest connect with NewClientWithOptions over plaintext.
  • substrate.ResourceLimits and its test. The controller resolves profile limits itself.
  • guest.Dial, a one-argument wrapper over DialTarget.
  • The server's storedStatus, a wrapper over store.StoredStatus, which TestStoredStatus now calls.

With that wrapper gone, guest.DialTarget is renamed Dial and guest.DialTargetTLS is renamed DialTLS. skills/substrate/SKILL.md is updated to match.

Updates #703

Remove six functions that no binary reaches:

- metadata.Server.IsWorkspaceReady and Server.ProbeAddr. The metadata
  tests move into package metadata and read the probe listener's
  address from the Server.
- substrate.NewClient. The reconciler tests and substratetest connect
  with NewClientWithOptions over plaintext.
- substrate.ResourceLimits and its test. The controller resolves
  profile limits itself.
- guest.Dial, a one-argument wrapper over DialTarget.
- The server's storedStatus, a wrapper over store.StoredStatus, which
  TestStoredStatus now calls.

With that wrapper gone, guest.DialTarget is renamed Dial and
guest.DialTargetTLS is renamed DialTLS. skills/substrate/SKILL.md is
updated to match.

Updates #703
@rakyll
rakyll requested a review from yongruilin November 22, 2026 22:35
@rakyll
rakyll requested a review from mayawang as a code owner November 22, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant