Preserve zero-filled data directives - #81
Merged
Merged
Conversation
zhangzhenghao
force-pushed
the
fix-zero-directives
branch
3 times, most recently
from
September 25, 2026 03:10
d77c171 to
46802ea
Compare
zhangzhenghao
force-pushed
the
fix-zero-directives
branch
2 times, most recently
from
September 25, 2026 03:24
10af4c4 to
af1e2b3
Compare
zhangzhenghao
force-pushed
the
fix-zero-directives
branch
from
September 25, 2026 03:32
af1e2b3 to
3e577b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Problem
Compiler-generated constant pools can contain directives that GoAT did not parse. Dropping them shortens generated data symbols, shifts later fields, and can make aligned SIMD loads fault.
The original amd64 failure used
.zero. Cross-platform reproduction also found:.space count[, fill]on several targets..base64 "..."for repeated initialized bytes on ppc64le.Solution
.zero count[, fill]..space count[, fill]..base64data directives.teststhat makes target compilers emit these directives and verifies zero bytes, filled bytes, and subsequent field offsets.Verification
go test ./...go vet ./.../4and/2DATA records and assembles