Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tox matrix includes Python 3.8, but Ruff has no target-version setting. Its current default reports 5 B905 violations suggesting
zip(..., strict=...), a keyword unavailable on Python 3.8. The prescribed format check also fails on two adjacent string literals.Set Ruff's target to the oldest Python version in the tox matrix. Join only the two literals required by the format check; their exact string values are unchanged. This lets the prescribed lint and formatting checks pass without introducing unsupported syntax or changing runtime behavior.
Validation: unchanged base has 5 lint errors and 2 files failing formatting. After the three-file correction,
tox run -e rufflint,ruffformatcheckpasses both environments with 27 files formatted. All 58 SortedDict tests pass, exact literal-value equality was verified, andgit diff --checkpasses.Prepared with AI assistance.