Skip to content

Keep lint checks compatible with supported Python 3.8 - #259

Open
xiehuanyi wants to merge 1 commit into
grantjenks:masterfrom
xiehuanyi:fix-supported-python-lint
Open

xiehuanyi wants to merge 1 commit into
grantjenks:masterfrom
xiehuanyi:fix-supported-python-lint

Conversation

@xiehuanyi

Copy link
Copy Markdown

The tox matrix includes Python 3.8, but Ruff has no target-version setting. Its current default reports 5 B905 violations suggesting zip(..., strict=...), a keyword unavailable on Python 3.8. The prescribed format check also fails on two adjacent string literals.

Set Ruff's target to the oldest Python version in the tox matrix. Join only the two literals required by the format check; their exact string values are unchanged. This lets the prescribed lint and formatting checks pass without introducing unsupported syntax or changing runtime behavior.

Validation: unchanged base has 5 lint errors and 2 files failing formatting. After the three-file correction, tox run -e rufflint,ruffformatcheck passes both environments with 27 files formatted. All 58 SortedDict tests pass, exact literal-value equality was verified, and git diff --check passes.

Prepared with AI assistance.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 18:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants