Repository navigation
fix: address security scan findings across ATS and Mass Payout - #1411
Open
nadinedelia wants to merge 1 commit into
Open
nadinedelia wants to merge 1 commit into
nadinedelia wants to merge 1 commit into
Conversation
Contracts and deploy scripts
- BusinessLogicResolver proxy is initialized in its deployment transaction
- Selector blacklist changes emit BlacklistSelectorsAdded/Removed
- LifeCycleCashFlow proxy is initialized in its deployment transaction,
the implementation disables initializers, initial role grants emit RoleGranted
- Percentage snapshot payouts reuse the pool captured on the first paid batch
- executePercentageSnapshotByAddresses rejects percentages above 100%
- A zero snapshot amount no longer marks a holder as paid
- Deployment scripts report lookup/detection/baseline failures instead of swallowing them
SDKs and apps
- ATS and Mass Payout SDKs redact custodial credentials, RPC API keys,
mirror node URLs and WalletConnect signatures from logs
- Mass Payout backend: listener config DTO and mirror host allow-list,
page size and metadata lookup caps, generic client errors, audit log
line per state-changing request, docker-compose credentials from .env
- Docs: the Mass Payout backend has no built-in authentication and must
run behind the adopter's gateway on a private network
- Web apps: dev servers accept localhost origins only, raw SDK errors are
no longer shown, form values and API URLs are no longer logged
CI
- persist-credentials: false on checkouts that don't push
- ${{ }} expressions moved out of run: scripts into env
- id-token: write scoped to the publishing job, minimal workflow permissions
- Secrets withheld from pull_request runs, package cache off for publishing
- Dependabot cooldown
Signed-off-by: Nadine D’Elia <nadine.delia@yahoo.com>
✅ Deploy Preview for asset-tokenization-studio-hedera ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nadinedelia
requested review from
RaphaelMessian,
jeromy-cannon and
rbarker-dev
November 3, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the findings from the internal security scan of this repo that were not already covered by the Halborn audit work now on
main.Contracts and deploy scripts
initializeBusinessLogicResolver.addSelectorsToBlacklist/removeSelectorsFromBlacklistemitBlacklistSelectorsAdded/BlacklistSelectorsRemoved.scripts/deploy.ts. The implementation calls_disableInitializers(), and initial role grants emitRoleGranted.executePercentageSnapshotByAddressesenforces the 100% cap, like the paged variant already does.failed, so they can be paid later.SDKs and apps
BLOCKCHAIN_MIRROR_NODE_ALLOWED_HOSTS), checked on save and before every poll.AUDIT_ACTOR_HEADER, body values never logged). docker-compose reads its credentials from.envand binds to 127.0.0.1.CI
persist-credentials: falseon checkouts that don't push.${{ }}insiderun:moved intoenv:.id-token: writescoped to the publishing job, minimal workflow and job permissions.pull_requestruns, package cache disabled on publish/release jobs.The three release and docs jobs that push (tag pushes in 002/003, doc regeneration in 106) keep
persist-credentials: trueexplicitly.Testing
RoleGrantedemitted for the initial rolesNotes for reviewers
@hashgraph/asset-tokenization-contracts7.0.0. ATS 9.0.0 changed thegetERC20Metadatalayout, soLifeCycleCashFlow.initializereverts against 9.0 assets. This is pre-existing and not changed here. The testnet payout check used the suite'sAssetMockfor that reason.scripts/deploy.tspasses a separately deployed ProxyAdmin asinitialOwnerof an OZ 5TransparentUpgradeableProxy, which deploys its own ProxyAdmin. This is pre-existing and not changed here.