Repository navigation
Conversation
A broken task is a task state, so it belongs where tasks are already listed, not on a separate page. The task list shows a red skull in the status cell for a broken task (from the isBroken aggregate), the edit page shows a banner with the reason (isBroken plus brokenReason), and a row action clears the broken state by deleting the BrokenTask. Regenerates the API client for the new aggregates.
thatux
changed the title
Review fixes for the broken-task UI: - markNotBroken now catches failures on both the lookup and the delete and shows an error message, matching the Clear row action instead of failing silently. - Align the Broken Error Window tooltip with the server config description. - Revert two unrelated reformatting hunks (a stray blank line in the header menu builder and a resplit renderTaskLink signature) that were not part of this change.
The supertask row already carries the skull (its wrapper is broken when any subtask is), but the subtask list in the supertask modal rendered only each subtask's run status. Request the task isBroken aggregate for the subtasks and flag a broken subtask with the same red skull the top-level list uses, so the failing subtask reads at a glance while the others keep running.
…dable - Move the "Mark not broken" button to the right of the reason, vertically centered, as a green filled button with a healing icon (matching the Clear Broken Task row action). - Add a hover tooltip hinting the attack command likely needs changing to repair the task. - Clamp a long broken reason to two lines with an ellipsis and let the operator click or key it to expand the full error; keyboard accessible (role, tabindex, enter/space).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on the server PR
hashtopolis/server#2509 (issue #884), which adds the
isBroken/brokenReasonaggregates and the broken-task config this UI reads.Broken is a task state, so it lives with the tasks, not on a separate page.
Changes
faSkullCrossbones) in the status cell for abroken wrapper, and a Clear row action.
brokenReason), and a Mark not broken button. Editing the command alsoclears it (server side).
BrokenTaskvia thebrokentasks endpoint and deletes it; gated on task update.
brokenTaskThreshold,brokenAgentThreshold,brokenErrorWindowexposed in the config UI.
Testing