Skip to content

chore(deps): update js-yaml to version 5.4.1 in package.json and package-lock.json - #2683

Merged
manishdait merged 1 commit into
hiero-ledger:mainfrom
MonaaEid:chore/2679-update-js-yaml
Oct 1, 2026
Merged

manishdait merged 1 commit into
hiero-ledger:mainfrom
MonaaEid:chore/2679-update-js-yaml

Conversation

@MonaaEid

@MonaaEid MonaaEid commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Description:
This pull request updates the js-yaml dependency in the GitHub Actions scripts to address potential security or compatibility issues. The update ensures that the project uses the latest compatible version of js-yaml.

Dependency updates:

  • Bumped js-yaml version from 5.2.3 to 5.4.1 in both package.json and package-lock.json for .github/scripts to ensure use of a more recent and secure version.

Related issue(s):
Fixes #2679

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…age-lock.json

Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:45
@MonaaEid
MonaaEid requested review from a team as code owners October 1, 2026 14:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added approved Issue has been approved by team member dependencies Pull requests that update a dependency file labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: hiero-ledger/hiero-sdk-python/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4ca2876c-5837-4b81-b7f1-2f3289851abb

📥 Commits

Reviewing files that changed from the base of the PR and between b9cfe74 and c19630b.

⛔ Files ignored due to path filters (1)
  • .github/scripts/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • .github/scripts/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The .github/scripts/package.json override for js-yaml changes from ^5.2.3 to ^5.4.1.

Changes

js-yaml Override

Layer / File(s) Summary
Update js-yaml override
.github/scripts/package.json
The override version changes from ^5.2.3 to ^5.4.1.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to c1963

The scripts dependency is set to the reported fixed version, and the lockfile matches. No actionable merge risk is apparent.

Architecture Summary

Architecture risk: 🔵 Low · up to c1963

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/scripts/package.json: The js-yaml override version changes from ^5.2.3 to ^5.4.1.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the js-yaml dependency update and names the affected package files. It accurately summarizes the main change.
Description check ✅ Passed The description directly explains the js-yaml version update, its security or compatibility purpose, and the related issue.
Linked Issues check ✅ Passed PR #2683 updates .github/scripts/package.json from js-yaml ^5.2.3 to ^5.4.1. Issue #2679 identifies versions through 5.4.0 as affected. The PR summary also reports the corresponding `package-l…
Out of Scope Changes check ✅ Passed The reported changes update js-yaml in the GitHub scripts dependency declarations. The change directly addresses the vulnerability in issue #2679. No unrelated implementation or behavior change is r…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review labels Oct 1, 2026
@manishdait
manishdait merged commit b9b8a58 into hiero-ledger:main Oct 1, 2026
27 of 30 checks passed
@MonaaEid MonaaEid added this to the v0.3.0 milestone Oct 1, 2026
@MonaaEid
MonaaEid deleted the chore/2679-update-js-yaml branch October 1, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Issue has been approved by team member dependencies Pull requests that update a dependency file open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

js-yaml vulnerability: maxTotalMergeKeys does not limit CPU use for empty merge sources

5 participants