Skip to content

chore: Override transitive dependencies for jest - #2760

Merged
danielmarv merged 2 commits into
hiero-ledger:mainfrom
manishdait:chore/dependabot-alert-50-51
Nov 5, 2026
Merged

danielmarv merged 2 commits into
hiero-ledger:mainfrom
manishdait:chore/dependabot-alert-50-51

Conversation

@manishdait

@manishdait manishdait commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description:
This PR addresses dependabot security alerts by adding npm overrides for the vulnerable minimatch dependencies.

Changes Made

  • Add npm overrides for minimatch.
  • Regenerate package-lock.json with the resolved dependency versions.

Related issue(s):

Fixes #2759

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@manishdait manishdait added the time pass Need to wait certain amount of time label Nov 2, 2026
@github-actions github-actions Bot added pending-review skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues labels Nov 2, 2026
@manishdait manishdait changed the title chore: Fix vulnerable in transitive dependencies for jest chore: Override transitive dependencies for jest Nov 2, 2026
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
manishdait force-pushed the chore/dependabot-alert-50-51 branch from 374566d to 20353d1 Compare November 2, 2026 20:52
@manishdait
manishdait marked this pull request as ready for review November 5, 2026 08:22
@manishdait
manishdait requested review from a team as code owners November 5, 2026 08:22
@github-actions github-actions Bot added open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review labels Nov 5, 2026
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Walkthrough

The JavaScript scripts package adds an override that sets the minimatch version range to ^11.0.4.

Changes

JavaScript Script Dependency Override

Layer / File(s) Summary
Pin the minimatch override
.github/scripts/package.json
The package manifest adds an override for minimatch at version range ^11.0.4.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Moderate · up to 90bc2

The dependency override can break JavaScript test runs with coverage enabled. Use compatible patched dependencies or upgrade the affected consumers together before merging.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Linked issue #2759 has two coding requirements: (1) add minimatch overrides in .github/scripts/package.json, and (2) regenerate the lock file. Requirement (1) is met in the summary. The summary sh… Provide reviewable evidence that the regenerated lock file resolves minimatch to a version that fixes Dependabot alerts 50 and 51. Evidence can be the lock file entries for minimatch taken from the diff, or a statement of the resolved v…
Passed Passed checks: 4 passed

Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding overrides for Jest transitive dependencies.
Description check Passed The description directly explains the minimatch overrides, lockfile regeneration, security alerts, and linked issue.
Out of Scope Changes check Passed The visible change is a single added minimatch override line in .github/scripts/package.json. This change directly implements #2759. No unrelated code, configuration, or documentation change appea…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Out of Scope Changes check

Explanation

The visible change is a single added minimatch override line in .github/scripts/package.json. This change directly implements #2759. No unrelated code, configuration, or documentation change appears in the summary. The lock file change is the regeneration that #2759 requests. Its contents are excluded from review by the !**/package-lock.json rule, so this assessment does not confirm that the lock file contains only dependency resolution changes. No evidence shows an unrelated change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Linked Issues check

Explanation

Linked issue #2759 has two coding requirements: (1) add minimatch overrides in .github/scripts/package.json, and (2) regenerate the lock file. Requirement (1) is met in the summary. The summary shows one added line that sets the minimatch override to ^11.0.4. Requirement (2) cannot be verified. The lock file .github/scripts/package-lock.json is listed in ignored_files, excluded by the rule !**/package-lock.json. Its contents were not reviewed. The review therefore cannot confirm that the lock file resolves minimatch to a patched version. The review also cannot confirm that ^11.0.4 is outside the vulnerable ranges for Dependabot alerts 50 and 51. Those alert ranges are not in the supplied evidence. The deepmerge note is informational and adds no coding requirement.

Resolution

Provide reviewable evidence that the regenerated lock file resolves minimatch to a version that fixes Dependabot alerts 50 and 51. Evidence can be the lock file entries for minimatch taken from the diff, or a statement of the resolved versions. Provide the vulnerable version ranges of alerts 50 and 51 so the override can be checked against them.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4d2bab9 and 90bc2ac.

Files ignored due to path filters: 1

  • .github/scripts/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1

  • .github/scripts/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread .github/scripts/package.json Resolved
@danielmarv danielmarv removed the time pass Need to wait certain amount of time label Nov 5, 2026
@danielmarv
danielmarv merged commit 5bb58a5 into hiero-ledger:main Nov 5, 2026
27 of 30 checks passed
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

👋 Hi @manishdait! Great work completing a Beginner issue! 🎉

Thanks for your contribution! 🚀

Here are some issues you might want to explore next:

🌟 Stay connected:

Happy coding! 🚀
— Hiero Python SDK Team

@manishdait manishdait added this to the v0.3.1 milestone Nov 5, 2026
@manishdait
manishdait deleted the chore/dependabot-alert-50-51 branch November 12, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address dependabot alerts for jest dependencies

5 participants