Skip to content

Fix toJSON() return type: should be string instead of object #151

Description

@huan

This function should return a type string instead of object

https://github.com/zixia/node-facenet/blob/b1e4f4b62383699d4c2e670abfe00613e47d0828/src/face.ts#L331

According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify:

The JSON.stringify() method converts a JavaScript value to a JSON string
JSON.stringify() converts a value to JSON notation representing it: If the value has a toJSON() method, it's responsible to define what data will be serialized.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions