Skip to content

Fix Ministral3 export for batched images case - #2110

Open
p-wysocki wants to merge 5 commits into
huggingface:mainfrom
p-wysocki:fix_ministral
Open

p-wysocki wants to merge 5 commits into
huggingface:mainfrom
p-wysocki:fix_ministral

Conversation

@p-wysocki

@p-wysocki p-wysocki commented Nov 6, 2026 •

Copy link
Copy Markdown

What does this PR do?

The model is currently exported using a single example image, so the exported model only works with one image even though its batch size seems dynamic. Batch > 1 fails in OVVP as mentioned in the ticket.

After the change, the vision model is run once per image. Added new test.

Ticket

CVS-199345

@p-wysocki p-wysocki changed the title Fix Mistral3 inference with batched images Fix Mistral3 export for batched images case Nov 6, 2026
@p-wysocki p-wysocki changed the title Fix Mistral3 export for batched images case Fix Ministral3 export for batched images case Nov 6, 2026

@echarlaix echarlaix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-wysocki why not fixing export instead ?

@p-wysocki

p-wysocki commented Nov 9, 2026 •

Copy link
Copy Markdown
Author

why not fixing export instead ?

Fixed, it was due to a wrong assumption about the repo.

@p-wysocki
p-wysocki requested a review from echarlaix November 9, 2026 14:33
del transformers_model, ov_model
gc.collect()

def test_mistral3_batched_images(self):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a common test for batched images. Could you please check? I don't want to have model-specific test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants