Repository navigation
Fix PointCloud examples - #2853
ftoromanoff wants to merge 4 commits into
Conversation
7c83201 to
18e7b27
Compare
f6f3794 to
2c6fe32
Compare
2c6fe32 to
7facdb8
Compare
|
@ketourneau I've taken the liberty of assigning you since you're listed as a point cloud expert in the |
| geometry.boundingBox.getSize(size); | ||
| geometry.boundingBox.getCenter(lookAt); | ||
|
|
||
| view.camera3D.far = Math.max(2.0 * size.length(), view.camera3D.far); |
There was a problem hiding this comment.
Las doesn't appear unless I move the camera.
I think it's missing :
view.camera3D.updateProjectionMatrix();
There was a problem hiding this comment.
I keep the previous behaviour (before the example stoped working) but it will be a nice addition to fix this bug. Thanks
| cmd.reject(err); | ||
| this.counters.failed++; | ||
| if (__DEBUG__ && this.counters.failed < 3) { | ||
| if ((__DEBUG__ && this.counters.failed < 5) || !__DEBUG__) { |
There was a problem hiding this comment.
Is it a missprint ?
Maybe you add !__DEBUG___ for debuging ? If it's intentional, why not remove the “if”?
There was a problem hiding this comment.
Currently, if tall errors are well catched, itowns will only logged the 2 first errors and will log the follwing one if __DEBUG__ is false, what i find very confusing...
In my opinion we should log all errors in the production mode and for the debug mode, as we might expect too many errors, we should be able to limit the logging to the first errors. (and why not have all the other errors gathered together, what I have done in the last version)
| r.clampOBB.updateMatrixWorld(true); | ||
| this.root.children[i] = r; | ||
| }); | ||
| }).catch(() => {}); |
There was a problem hiding this comment.
Why empty catch here ? Maybe it's a missprint ?
There was a problem hiding this comment.
if promisedRoot failed, we already have the error caught by the scheduler thus we don't want to have it uncaught and redirect to the console..
| mockSubRoot.load = promisedRoot.then(root => root.load); | ||
| mockSubRoot.load = promisedRoot | ||
| .then(root => root.load) | ||
| .catch(() => {}); |
There was a problem hiding this comment.
Why empty catch here ? Maybe it's a missprint ?
There was a problem hiding this comment.
same reason.
before adding these lines, when there is an error raised, we had it redirect to the console 3 times in addition to have it handled by the scheduler...
| }; | ||
| context.scheduler.execute(cmd); | ||
|
|
||
| context.scheduler.execute(cmd).catch(() => {}); |
There was a problem hiding this comment.
Why empty catch here ? Maybe it's a missprint ?
9bcea10 to
00ec28e
Compare
00ec28e to
6e85bf4
Compare
This branch has not been deployed
3 participants
Fix linked to the fellowing issues: