Repository navigation
Conversation
Editor::highlight() re-shapes lines with new attributes (e.g. bold) via shape_as_needed, but the cached selection still holds the caret position computed from the previous, unstyled layout, so the caret is drawn at the wrong x-offset until the next perform() clears the cache. Clear it after re-shaping, as the other mutators (perform, move_to, update) already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor::highlight() re-shapes lines with new attributes (e.g. bold) via shape_as_needed, but the cached selection still holds the caret position computed from the previous, unstyled layout, so the caret is drawn at the wrong x-offset until the next perform() clears the cache. Clear it after re-shaping, as the other mutators (perform, move_to, update) already do.
This fixes https://git.disroot.org/trougnouf/cfait/issues/24 . I've only tested with Iced 0.14.0 (where I backported the fix) but the behavior seems identical. (I can create a self-contained test on master if needed.)