Skip to content

fix: restrict search inputs #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calebwongg wants to merge 8 commits into
base: main
Choose a base branch
from
+15 −3
Open

fix: restrict search inputs #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
38137a3
feat: sanitize section code input
calebwongg Nov 4, 2026
96519f3
feat: sanitize instructor field iput
calebwongg Nov 4, 2026
dc21dd8
feat: sanitize unit field input
calebwongg Nov 4, 2026
c7e0fb3
fix: allow hyphens for section codes
calebwongg Nov 4, 2026
2ddce48
fix: preserve decimal points for decimal units
calebwongg Nov 10, 2026
f914f6a
fix: delete all second decimal points
calebwongg Nov 10, 2026
e768844
Merge branch 'main' of https://github.com/icssc/AntAlmanac into cwong…
calebwongg Nov 10, 2026
ed3720b
Merge branch 'main' of https://github.com/icssc/AntAlmanac into cwong…
calebwongg Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...oursePane/SearchForm/ManualSearch/AdvancedSearch/AdvancedSearchFields/InstructorField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const InstructorField = memo(() => {
textFieldProps={{
type: 'search',
value: instructor,
onChange: (event) => setInstructor(event.target.value),
onChange: (event) => setInstructor(event.target.value.replace(/[0-9]/g, '')),
placeholder: 'Last name only',
fullWidth: true,
}}
Expand Down
14 changes: 13 additions & 1 deletion ...ane/CoursePane/SearchForm/ManualSearch/AdvancedSearch/AdvancedSearchFields/UnitsField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,19 @@ export const UnitsField = memo(() => {
label="Units"
textFieldProps={{
value: units,
onChange: (event) => setUnits(event.target.value),
onChange: (event) => {
const upper = event.target.value.toUpperCase();

if (upper.startsWith('VAR')) {
setUnits('VAR');
} else if ('VAR'.startsWith(upper)) {
setUnits(upper);
} else {
const cleaned = upper.replace(/[^0-9.]/g, '');
const finalValue = cleaned.replace(/(\..*?)\./g, '$1');
setUnits(finalValue);
Comment on lines +13 to +23

@Choollol Choollol Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that typing a number or dot resets the VAR progress? For example typing V, A, 1 shows V, VA, 1

@calebwongg calebwongg Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah theres no use case where anyone would type VAR + "some number", right? Because VAR is the abbreviation for variable unit courses, where students pick how many units their course is worth at enrollment. Theres no use case where someone would deliberately search for example VAR1 or something related because either you search a number or you search VAR on its own.

At least this was my thought process correct me if im wrong

}
},
Comment on lines +13 to +25

@sicn4rf sicn4rf Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to preserve decimal points here as well, there are cases where a course's units can include a decimal point

Image

type: 'search',
placeholder: 'ex. 4 or VAR',
fullWidth: true,
Expand Down
2 changes: 1 addition & 1 deletion ...ents/RightPane/CoursePane/SearchForm/ManualSearch/ManualSearchFields/SectionCodeField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const SectionCodeField = memo(() => {
const [sectionCode, setSectionCode] = useCourseSearchParam('sectionCode');

const handleChange = (event: ChangeEvent<{ value: string }>) => {
setSectionCode(event.target.value);
setSectionCode(event.target.value.replace(/[^0-9,-]/g, ''));
};

return (
Expand Down
Loading