Repository navigation
build: run the privacy check in verify and catch Windows paths - #15
Merged
Merged
Conversation
scripts/privacy-check.mjs was added but no npm script, verify step or workflow ever ran it, so tracked files were never scanned for personal paths or secrets. Its Windows pattern also only matched JSON-escaped paths (C:\Users\), missing the common single-backslash form. Add a check:privacy script, run it first in verify (which CI and the release workflow call), and match both forms of Windows profile path.
autoantohaki
force-pushed
the
fix/run-privacy-check
branch
from
October 22, 2026 00:10
d5dbf46 to
90b0306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Summary
Before:
scripts/privacy-check.mjsexisted, but no npm script,verifystep or workflow ran it, so tracked files were never scanned for personal paths or keys. Its Windows pattern also only matched the JSON-escaped formC:\Users\. A plainC:\Users\name\...path passed the check.After:
npm run check:privacyruns first innpm run verify, so CI and the release workflow enforce it. The Windows pattern matches both single- and double-backslash profile paths. The current tree passes.How: a new
check:privacyscript inpackage.json, regex patterns in the check, and a CHANGELOG line. To verify, I staged a file containingC:\Users\mau\file: the new check rejects it and the version onmainpasses it.Verification
npm run verify