Skip to content

Fix: Deduplicate list elements in 'append_to_list' with 'flatten' #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ipspace merged 1 commit into from
Oct 31, 2026
Merged

Fix: Deduplicate list elements in 'append_to_list' with 'flatten' #4014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions netsim/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,22 @@ def get_a_list(x: typing.Any, ctx: typing.Optional[str] = None) -> list:

* Return if the box is None
* Create an empty list if it does not exist
* Append the item to the list
* Convert a scalar value into a one-element list
* Append the item to the list if it's not already there
* With 'flatten' set, append the list elements that are not already in the list
"""
def append_to_list(BX: typing.Optional[Box], list_name: str, item: typing.Any, flatten: bool = False) -> list:
if BX is None:
return []

if not list_name in BX:
BX[list_name] = []
elif not isinstance(BX[list_name],list):
BX[list_name] = [ BX[list_name] ]

if not item in BX[list_name]:
if flatten and isinstance(item,list):
BX[list_name].extend(item)
else:
BX[list_name].append(item)
for element in item if flatten and isinstance(item,list) else [ item ]:
if not element in BX[list_name]:
BX[list_name].append(element)

return BX[list_name]

Expand Down
Loading