Use JSONField for BasePayment.attrs - #306
Conversation
|
Hi! I'm actually wanting to use this, since 2.2 has already been dropped, can I give you a hand with this? |
|
I've rebased this, but it would be good to have some more testing before merging it. |
|
I'll start using it right away, and let you know, my system processes a couple thousands purchases a day, so it's a fair trial. |
|
Tests seem to still be failing on a bunch on combinations of Django + Python, so I'd hold testing it on a production environment for a bit. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 78.42% 77.95% -0.48%
==========================================
Files 29 29
Lines 1979 1964 -15
Branches 244 244
==========================================
- Hits 1552 1531 -21
- Misses 310 317 +7
+ Partials 117 116 -1 ☔ View full report in Codecov by Sentry. |
WhyNotHugo
changed the title
|
Looks like f4dfa5e is breaking some tests, but it's not clear to me why. |
|
Split the first commit into #385 |
b77385d to
6082843
Compare
af60835 to
a18479b
Compare
| raise PaymentError(e) from e | ||
| else: | ||
| payment.attrs.refund = json.dumps(refund) | ||
| payment.extra_data["refund"] = json.dumps(refund) |
There was a problem hiding this comment.
i believe this should be payment.extra_data["refund"] = refund
|
Good catch, updated. |
|
Rebased |
2 participants
Need to wait until Django 2.2 is EOL.