Skip to content

Correct regional ECS task-definition inspection permission #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jckail merged 1 commit into from
Oct 7, 2026
Merged

Correct regional ECS task-definition inspection permission #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion infra/lib/github-oidc-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ export class GithubOidcStack extends cdk.Stack {
role.addToPolicy(new iam.PolicyStatement({
sid: "InspectMigrationTask",
actions: ["ecs:DescribeTaskDefinition"],
resources: [arn("ecs", "task-definition/TemplateApp*")],
// AWS authorizes this read API against "*", even for an exact task ARN.
// Rollout independently binds the returned task to this account/candidate.
resources: ["*"],
conditions: { StringEquals: { "aws:RequestedRegion": this.region } },
}));
role.addToPolicy(new iam.PolicyStatement({
sid: "InspectMigrationCluster",
Expand Down
9 changes: 9 additions & 0 deletions infra/test/github-deployment-iam.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,12 @@ test("hosted external qualification reads scoped metadata and assets without pro
const values = statements.filter(statement => JSON.stringify(statement.Action).includes("secretsmanager:GetSecretValue"));
assert.equal(values.length, 1); assert.equal(values[0].Sid, "ReadClerkBuildConfiguration");
});

test("migration task inspection uses AWS-supported resource scope and stays regional", () => {
const statements = Object.values(template().findResources("AWS::IAM::Policy"))
.flatMap(resource => resource.Properties.PolicyDocument.Statement);
const inspection = statements.find(statement => statement.Sid === "InspectMigrationTask");
assert.equal(inspection.Action, "ecs:DescribeTaskDefinition");
assert.equal(inspection.Resource, "*");
assert.deepEqual(inspection.Condition, { StringEquals: { "aws:RequestedRegion": "us-east-1" } });
});
Loading