Repository navigation
Accept ECS empty entry-point normalization for migration tasks - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live ECS task-definition response normalizes the migration container's omitted entry point to an empty array. The release guard rejected that valid AWS response as an entry-point override, so qualification stopped before migration.
Accept only an absent entry point or an empty array and preserve the image's entry point in candidate registration. Continue rejecting nonempty overrides and invalid shapes. Use the observed empty entry-point, mount-point and port-mapping arrays in the deployment fixtures.
Validation: 58 focused hosted-helper/rollout tests pass, including acceptance of AWS normalization and refusal of override/invalid forms. The corrected guard accepts the actual AWS migration definition. Independent live checks confirm zero service/scaling capacity and disabled schedules. Exact5db4bc5 CI37560583407 and CodeQL37560583402 passed, including all application builds, actual Docker/PostgreSQL smoke, MCP and infrastructure checks. The AWS stack remains inactive; this does not establish migration or activation.