Repository navigation
ci: dry-run the wheel build on PRs; only releases publish - #52
Merged
Merged
Conversation
The wheel/sdist matrix only ran on release, so a break (e.g. the new cp314 target) would first surface at release time. Also trigger it on pull requests touching the build configuration, gate upload_pypi on the release event so a dry run can never publish, and turn off fail-fast so one platform failing doesn't cancel the rest into misleading "cancelled" results. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to spatialgeometry!
Summary
Dry-run the wheel/sdist/Pyodide build on pull requests; only a release publishes.
The wheel matrix only ever ran on release, so a break (e.g. the new
cp314target from #47) would first surface at release time.pull_request, filtered topyproject.toml,CMakeLists.txtand the workflow file itself, so it only runs when the build configuration changes.upload_pypiongithub.event_name == 'release', so a dry run can never publish. Releasing is still a single click on "Publish release" and is still the only way to publish; the header comment says so.fail-fast: falseon the wheel matrix so one platform failing doesn't cancel the rest into misleading "cancelled" results.Cost: 4 platform runners (× CPython 3.10-3.14 each) plus the Pyodide wheel and sdist, a few minutes, only on PRs that touch those files.
This PR touches the workflow file itself, so its own CI run is the first real dry run (including the first
cp314wheel build).Related issue
Follows up #47 (Python 3.14 support) and #49 (pure Pyodide wheel).
Checklist
Nothing below is checked automatically -- this is a self-check for you before requesting review.
type: description)🤖 Generated with Claude Code