Repository navigation
Add page-specific keyboard shortcuts help - #1736
Open
djinnalexio wants to merge 1 commit into
Open
djinnalexio wants to merge 1 commit into
djinnalexio wants to merge 1 commit into
Conversation
Ctrl+? now opens the shortcuts dialog of the visible page instead of only in the book-viewer. - add a library shortcuts overlay (app-help-overlay) and rename book viewer shortcuts overlay (book-help-overlay) - add `utils.showHelpOverlay()` to build and present an overlay by name - have the app-level `win.show-help-overlay` action and <Ctrl+?> shortcut delegate to the visible page's `showHelpOverlay()`, falling back to the app overlay - the <ctrl+?> shortcut in book viewer is kept so it's visible in the UI
djinnalexio
force-pushed
the
add-page-specific-help-overlays
branch
from
October 20, 2026 09:36
6830d08 to
d8cc34e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl+? now opens the shortcuts dialog of the visible page instead of only in the book-viewer.
utils.showHelpOverlay()to build and present an overlay by namewin.show-help-overlayaction and <Ctrl+?> shortcut delegate to the visible page'sshowHelpOverlay(), falling back to the app overlayapp.js