Skip to content

NormalisableRange: Do not let a value that is no number pass as normalised #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yumasansansan wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

NormalisableRange: Do not let a value that is no number pass as normalised #1751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modules/juce_core/maths/juce_NormalisableRange.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,13 @@ class NormalisableRange

static ValueType clampTo0To1 (ValueType value)
{
auto clampedValue = jlimit (static_cast<ValueType> (0), static_cast<ValueType> (1), value);
// A value that is no number is not between nought and one either, and
// jlimit hands it back: every comparison with it is false. What it
// reaches is audio, as a sample that is no number, and the integer
// parameters, where converting it to an int is undefined. A proportion
// of nought, the bottom of the range, is the nearest value to it.
auto clampedValue = std::isnan (value) ? static_cast<ValueType> (0)
: jlimit (static_cast<ValueType> (0), static_cast<ValueType> (1), value);

// If you hit this assertion then either your normalisation function is not working
// correctly or your input is out of the expected bounds.
Expand Down
Loading