Skip to content

Fix flaky netlink and overlay cleanup tests - #473

Merged
chruffins merged 2 commits into
mainfrom
hypeship/test-agent-netlink-retry
Sep 2, 2026
Merged

Fix flaky netlink and overlay cleanup tests#473
chruffins merged 2 commits into
mainfrom
hypeship/test-agent-netlink-retry

Conversation

@chruffins

@chruffins chruffins commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

summary

Fixes two flaky Linux cleanup tests found by the test-agent:

  • retry interrupted netlink link dumps during orphaned TAP and traffic-control cleanup
  • use the existing bounded deletion helper in TestOverlayDiskCleanupOnDelete so the test tolerates hypervisor teardown completing after the first delete attempt

testing

  • go test ./lib/network
  • TestCreateInstanceWithNetwork passed 5 times
  • TestOverlayDiskCleanupOnDelete passed 5 times
  • full no-cache Linux suite passed 3 consecutive times (269s, 488s, 421s)

@chruffins
chruffins marked this pull request as ready for review September 2, 2026 17:22
@chruffins chruffins changed the title Retry interrupted netlink link dumps Stabilize netlink and overlay cleanup tests Sep 2, 2026
@chruffins chruffins changed the title Stabilize netlink and overlay cleanup tests Fix flaky netlink and overlay cleanup tests Sep 2, 2026
@chruffins
chruffins merged commit a39b4fa into main Sep 2, 2026
8 checks passed
@chruffins
chruffins deleted the hypeship/test-agent-netlink-retry branch September 2, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants