Conversation
…straint generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate index access constraints for arrays. In other words, for each array access
a[i], generate the constraint thatiis between 0 and the length of the array minus 1 (inclusive).If inductive or quantified variables are used in array index accesses, then we universally quantify them in the generated property.
This PR should not be merged until we have support for certain operators with lazy semantics, which we can use to mitigate spurious property violations as in the following example (the generated property for
A[i-1]is falsified wheniis0, even though it is in theelsebranch of the assignment)Side note -- analogous constraints are not generated for map index accesses due to situations like the following:
Above, index access constraint
0 in mwould raise a counterexample with a single timestep, even though the access is properly guarded, and there is not a straightforward way to address the situation.