Enforce the CMake C++ standard requirement - #348
Open
masterleinad wants to merge 1 commit into
Open
masterleinad wants to merge 1 commit into
masterleinad wants to merge 1 commit into
Conversation
JBludau
reviewed
Sep 15, 2026
| message(FATAL_ERROR "KokkosTools requires C++20") | ||
| endif() | ||
|
|
||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) |
Contributor
There was a problem hiding this comment.
Why not add CXX_STANDARD_REQUIRED to the Kokkos target?
Contributor
Author
There was a problem hiding this comment.
Which target do you mean?
Contributor
Author
There was a problem hiding this comment.
We are only linking with Kokkos::kokkos in the tests; the tools libraries don't dependent on kokkoscore.
Contributor
There was a problem hiding this comment.
Ok, I misunderstood the intend then
JBludau
approved these changes
Sep 15, 2026
| message(FATAL_ERROR "KokkosTools requires C++20") | ||
| endif() | ||
|
|
||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) |
Contributor
There was a problem hiding this comment.
Ok, I misunderstood the intend then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling with gcc-14 didn't work because we just used
-std=c++1zand couldn't find thefilesystemheader.