Repository navigation
docs: add Ky and Valibot to the comparison page #4675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply the legend to every official plugin row, or clarify it.
The legend defines β as "built in" and π‘ as "community or separate package." The Ky and Valibot plugins are separate extensions, and
packages/kubb/package.jsondoes not list either as a dependency. Their β cells therefore contradict the legend.The Zod, React Query, MSW, and other official plugin rows use the same β for separate extensions. Changing only the two new cells would leave the column inconsistent. Choose one rule for official plugins, either π‘ for separate packages or a legend definition that treats them as built in. Apply that rule to every Kubb-column cell that refers to an official plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changing this here. Every Kubb row on this page already uses β for an official
@kubb/*plugin, and the two new rows follow that rule. Rewording the legend would change how the whole table reads, which is outside this PR. Footnote 6 marks the two new plugins as beta.Generated by Claude Code