refactor(reporter): use badgelib for badge rendering - #962
Open
vladkens wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I came across jscpd and liked that it can publish duplication results as SVG badges alongside its other reports. The current renderer works, but badge layout and SVG generation are separate from jscpd's core task of detecting duplicated code and still need to be maintained.
I work on badges.ws and maintain badgelib, a tested Rust library for generating badges. This PR uses it for the rendering step while jscpd retains control over the reported values, thresholds, colors, labels, and output files.
The change is small and preserves the reporter's current behavior. The badges become slightly more compact, and the trade-off is adding a rendering dependency; in return, jscpd no longer needs to maintain its own SVG renderer. What do you think?
This change is