Sass 1.105 and its module system, with the CSS byte for byte as it was - #232
Merged
Merged
Conversation
Sass was pinned at 1.77.6 during the Svelte 5 upgrade to keep the build quiet. This moves to the current release and clears what it warns about, without changing a byte of the CSS it writes: - @use and @forward instead of @import, which Dart Sass 3 removes. global.scss loads the partials in the order it imported them; the mixins forward the breakpoints, so a component that took both from _mixins still does. The fontsource imports stay: plain CSS @import is not deprecated. - The colour helpers read channels through sass:color (color.channel) instead of the global red(), hue() and friends, and the contrast choice is an @if instead of the if() function. - Three rules declared properties after a nested rule. Sass now writes those into a second rule after the nested one, which reorders the cascade; they sit above the nested rules now, which is where Sass used to put them. Checked against a build of main: all 58 stylesheets are byte-identical, and all 1371 pages have the same element tree, text and head. No Sass warnings in svelte-check or the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #230, which pinned Sass at 1.77.6 to keep the build free of warnings. This moves to the current release (1.105) and clears everything it warns about, without changing the CSS:
@use/@forwardinstead of@import(removed in Dart Sass 3).global.scssloads the partials in the same order;_mixinsforwards the breakpoints, so components that took both from it still get them. Plain CSS@imports of fontsource stay (not deprecated).sass:color(color.channel) instead of the globalred(),hue()etc.; the contrast choice is an@ifinstead ofif().#article-content, the compare picker's.vs, the say page's.term) declared properties after a nested rule. Current Sass writes those into a second rule after the nested one, which changes the cascade; they now sit above the nested rules, where Sass used to put them.Checked
🤖 Generated with Claude Code