Repository navigation
Conversation
Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
Collaborator
|
@git-jxj Thank you for your attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Offset pagination with
--allsends the requested starting offset on the first page, but resets its counter to zero afterward. For--offset 2 --limit 2, the requests use offsets2, 2, 4, 5and duplicate the first fetched page.Initialize the counter from the resolved request query so both explicit offsets and specification defaults continue from the requested page. Regression tests exercise the generated command runtime against HTTP fixtures, including custom and encoded parameter names, different page sizes, total metadata, and an empty first page.
Verification
make checkgo test -race ./...go build ./...The new regressions fail against the original implementation and pass with this change.
Compatibility
Offset-based
--allnow advances from the starting offset already sent in the first request. The CLI usage documentation describes this behavior.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.