ra: write MTC fields to order - #9023
Conversation
ba87d46 to
8319d2f
Compare
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
1 similar comment
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
|
@jsha, this PR adds one or more new feature flags: OrderModelHasMTCFields. As such, this PR must be accompanied by a review of the Let's Encrypt CP/CPS to ensure that our behavior both before and after this flag is flipped is compliant with that document. Please conduct such a review, then add your findings to the PR description in a paragraph beginning with "CPS Compliance Review:". |
beautifulentropy
left a comment
beautifulentropy
left a comment
There was a problem hiding this comment.
One small error message nit, otherwise this all looks good to me.
63c7e05
3 participants
In the process, consolidate on returning (mtcLogID, mtcSerialNumber), not (mtcLogID, mtcEntryIndex). It's redundant but those two pieces of information are the most broadly useful ones. We don't want anyone outside the MTCA / MTCB doing bit math to make serial numbers.
Rearrange test setup for the SA slightly: reset feature flags in a cleanup step, not at the beginning of
initSA. That allows us to set a feature flag that takes effect at database setup time.Fixes #8912