Skip to content

test: remove self-hosted runner skips - #994

Open
liopeer wants to merge 1 commit into
mainfrom
test/remove-self-hosted-runner-skips
Open

liopeer wants to merge 1 commit into
mainfrom
test/remove-self-hosted-runner-skips

Conversation

@liopeer

@liopeer liopeer commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

What has changed and why?

Phase 1 of the CI speedup: remove the skips for self-hosted runners.

  • Remove 8 skipif(is_self_hosted_docker_runner) skips in test_train_task.py. They skipped tests on the self-hosted GPU runners because of insufficient shared memory, which is likely fixed on the deployment side.
  • Remove the unused is_self_hosted_docker_runner in test_predict_task.py.

This is a separate PR so that a nightly failure is easy to trace back to it.

How has it been tested?

  • tests/_commands/test_train_task.py and tests/_commands/test_predict_task.py pass locally (56 passed).
  • These skips never applied on GitHub-hosted runners, so PR CI does not change.

After merge

  • Check that the next lightly-train-private nightly (docker-gpu / docker-cpu runners) passes the re-enabled tests in test_train_task.py.
  • If they fail with a worker bus error: raise the runner's shared memory (--shm-size), or revert this PR.

Did you update the documentation?

  • Yes
  • Not needed (internal change without effects for user)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T19:45:06.253938Z 592c79b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant