Require a multithreaded runtime when setting up the node - #1071
Open
elnosh wants to merge 1 commit into
Open
Conversation
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Sep 8, 2026
tnull
left a comment
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Yeah, I guess it's better to be explicit about it. One comment though.
| /// | ||
| /// Note we require the given runtime to be of the `multithreaded` flavor. | ||
| #[cfg_attr(feature = "uniffi", allow(dead_code))] | ||
| pub fn set_runtime(&mut self, runtime_handle: tokio::runtime::Handle) -> &mut Self { |
Collaborator
There was a problem hiding this comment.
Can we return a new BuildError if the given handle does not belong to a multithreaded runtime?
We already note on `Node::start` that we require the outer runtime to be of the multithreaded flavor, but we never check it. We should, as our synchronous API methods enter the runtime via `block_in_place`, which panics on current-thread runtimes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
elnosh
force-pushed
the
runtime-err-check
branch
from
September 9, 2026 13:46
f1ae35f to
fd1a5e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already note on
Node::startthat we require the outer runtime to be of the multithreaded flavor, but we never check it.Given that this block_in_place panics if called from a current-thread runtime, it seems we should error rather than just silently allow it.
https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html#panics