LCORE-4200: Enable all ISC Ruff rules on CI

[tisnik]

Description

LCORE-4200: Enable all ISC Ruff rules on CI

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library [pyproject.toml + uv.lock]
• Bump-up dependent library [requirements.*.txt for Konflux]
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-4200

Summary by CodeRabbit

• Maintenance
  • Linting now checks for ISC004 violations; other configured exclusions remain unchanged.
• Tests
  • Updated a health-endpoint test to represent the mocked model-unavailable reason as a one-item tuple.

[tisnik]

/retest

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 2a94f94f-8d74-4f15-a505-125bd1268587

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc9340 and 5f7a68b.

📒 Files selected for processing (2)

• pyproject.toml
• tests/unit/app/endpoints/test_health.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (18)

• GitHub Check: E2E: server / ci / other
• GitHub Check: E2E: library / ci / shields
• GitHub Check: E2E: library / ci / default
• GitHub Check: E2E: library / ci / other
• GitHub Check: E2E: server / ci / shields
• GitHub Check: E2E: library / ci / skills
• GitHub Check: E2E: library / ci / mcp
• GitHub Check: E2E: library / ci / rbac
• GitHub Check: E2E: library / ci / authorized
• GitHub Check: E2E: server / ci / default
• GitHub Check: E2E: server / ci / skills
• GitHub Check: E2E: server / ci / authorized
• GitHub Check: E2E: server / ci / tls
• GitHub Check: E2E: server / ci / rbac
• GitHub Check: E2E: server / ci / mcp
• GitHub Check: build-pr
• GitHub Check: integration_tests (3.13)
• GitHub Check: integration_tests (3.12)

⚠️ CI failures not shown inline (1)

GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request: Failed

Conclusion: failure

View job details

Konflux kflux-prd-rh02/lightspeed-stack-0-8-on-pull-request has <b>failed</b>.
<ul>
<li><b>Namespace</b>: <a href="https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/lightspeed-core-tenant">lightspeed-core-tenant</a></li>
<li><b>PipelineRun:</b> <a href="https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/lightspeed-core-tenant/pipelinerun/lightspeed-stack-0-8-on-pull-request-65qdd">lightspeed-stack-0-8-on-pull-request-65qdd</a></li>
</ul>
<hr>
<h4>Task Statuses:</h4>
Pipeline lightspeed-core-tenant/lightspeed-stack-0-8-on-pull-request-65qdd can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "resolver type bundles\nname = rpms-signature-scan\n": error requesting remote resource: error getting "bundleresolver" "lightspeed-core-tenant/bundles-fc3c8acfbd6198a353ddf0c821c88db5": invalid tekton bundle quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2.2@sha256:***REDACTED_HIGH_ENTROPY_STRING***, error: the layer 0 does not contain a dev.tekton.image.apiVersion annotation

🔇 Additional comments (2)

pyproject.toml (1)

261-261: 🎯 Functional Correctness

CI already selects ISC004. pyproject.toml extends Ruff’s selection with ISC, and the CI command does not override it with --select. The requested verification is unnecessary.

tests/unit/app/endpoints/test_health.py (1)

147-150: LGTM!

---

Walkthrough

The Ruff configuration no longer ignores ISC004. The default-model-unavailable health test now sets its mocked failure reason as a one-element tuple.

Changes

Ruff lint configuration

Layer / File(s)	Summary
Update ignored lint rules pyproject.toml	ISC004 was removed from Ruff’s ignored rules.

Health endpoint test

Layer / File(s)	Summary
Update mocked failure reason tests/unit/app/endpoints/test_health.py	The test now configures the mocked failure reason as a one-element tuple. The text is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: asimurka

Merge Risk: ⚪ Minimal · up to 5f7a6

The lint rule is enabled in CI, and the health-test adjustment leaves the endpoint unchanged. The PR is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the change: removing the ISC004 ignore enables that Ruff rule on CI.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity	✅ Passed	No performance regression was introduced. The diff changes Ruff configuration and only adds grouping parentheses around a test string; it adds no algorithm, loop, API or database call, cache, or list …
Security And Secret Handling	✅ Passed	No security or secret-handling violation was introduced. The diff changes only the Ruff ignore list and a test mock value. It does not change endpoint authorization, production responses, logging, or …

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

✨ Simplify code

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}