Skip to content

LCORE-4606: Fixed quota handling in SQLite #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Oct 9, 2026
Merged

LCORE-4606: Fixed quota handling in SQLite #2874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/quota/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
UPDATE quota_limits
SET available=available+?, revoked_at=datetime('now')
WHERE subject=?
AND revoked_at < datetime('now', ?);
AND datetime(revoked_at, ?) <= datetime('now');
"""


Expand All @@ -54,7 +54,7 @@
UPDATE quota_limits
SET available=?, revoked_at=datetime('now')
WHERE subject=?
AND revoked_at < datetime('now', ?);
AND datetime(revoked_at, ?) <= datetime('now');
"""

INIT_QUOTA_PG = """
Expand Down
4 changes: 3 additions & 1 deletion src/runners/quota_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ def quota_revocation(

subject_id = get_subject_id(quota_limiter.type)

if quota_limiter.quota_increase is not None:
# do not update quota revocation date when the increase is set to zero
if quota_limiter.quota_increase is not None and quota_limiter.quota_increase > 0:
increase_quota(
connection,
increase_quota_statement,
Expand All @@ -226,6 +227,7 @@ def quota_revocation(
quota_limiter.period,
)

# do not update quota revocation date when the initial quota is set to zero
if quota_limiter.initial_quota is not None and quota_limiter.initial_quota > 0:
reset_quota(
connection,
Expand Down
Loading