Skip to content

Apply quality to all Vips image formats - #1662

Open
ousamabenyounes wants to merge 1 commit into
liip:2.xfrom
ousamabenyounes:bugfix-1601-vips-quality
Open

ousamabenyounes wants to merge 1 commit into
liip:2.xfrom
ousamabenyounes:bugfix-1601-vips-quality

Conversation

@ousamabenyounes

Copy link
Copy Markdown
Contributor
Q A
Branch? 2.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets Fix #1601
License MIT
Doc configuration.rst

Map the generic filter-set quality value to every format-specific quality option expected by the Vips driver. Existing explicit jpeg_quality values continue to take precedence.

Test verification (RED → GREEN)

On the upstream 2.x branch, the focused test failed because only the generic option reached the encoder:

Expected: quality, jpeg_quality, png_quality, webp_quality, heif_quality, avif_quality, jxl_quality
Actual:   quality
FAILURES!
Tests: 1, Assertions: 0, Failures: 1.

With this change:

OK (1 test, 3 assertions)
php-diff-coverage: PASS 3/3 changed executable lines covered

Full local CI also passed: container lint, 1,059 PHPUnit tests (23 existing skips), PHP CS Fixer, and PHPStan.

Comment thread Imagine/Filter/FilterManager.php Resolved
@ousamabenyounes
ousamabenyounes force-pushed the bugfix-1601-vips-quality branch from aa8a160 to 623215d Compare October 13, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VIPS + Qualty params not working

2 participants