Repository navigation
Apply quality to all Vips image formats - #1662
Open
ousamabenyounes wants to merge 1 commit into
Open
ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
dbu
reviewed
Aug 31, 2026
ousamabenyounes
force-pushed
the
bugfix-1601-vips-quality
branch
from
October 13, 2026 05:58
aa8a160 to
623215d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map the generic filter-set
qualityvalue to every format-specific quality option expected by the Vips driver. Existing explicitjpeg_qualityvalues continue to take precedence.Test verification (RED → GREEN)
On the upstream
2.xbranch, the focused test failed because only the generic option reached the encoder:With this change:
Full local CI also passed: container lint, 1,059 PHPUnit tests (23 existing skips), PHP CS Fixer, and PHPStan.