Repository navigation
Add Twig 4 support - #1673
Open
winniezzz wants to merge 1 commit into
Open
Add Twig 4 support#1673winniezzz wants to merge 1 commit into
winniezzz wants to merge 1 commit into
Conversation
|
Thanks |
dbu
reviewed
Oct 30, 2026
dbu
left a comment
dbu
left a comment
Collaborator
There was a problem hiding this comment.
thanks for looking into this. i am happy to merge the return type change and the additional tests already - we can only allow twig 4 once its released.
you are adding a bunch of missing tests, which i appreciate. but please change the FilterExtensionTest & LazyFilterExtensionTest to use the same base class with the test cases. unless i miss something, both extensions should have the exact same behaviour, so only the setup should be different, but the tests should be the same.
winniezzz
changed the title
winniezzz
force-pushed
the
twig-4-support
branch
from
November 2, 2026 07:54
95ab9cc to
9130a3d
Compare
winniezzz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twig 4 adds native return types to ExtensionInterface, so the deprecated FilterExtension, used by the default "legacy" twig mode, failed with a fatal error. Add the missing array return type, widen the twig/twig constraint, add tests rendering real Twig templates and a CI job running the suite against Twig 4.
Refs #1672