Repository navigation
[TAS-6933] 🔧 Add bookmatter publisher subdomain - #1706
Conversation
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟡 Changes recommended
The change expands approved publisher hosts to include bookmatter.<apex> but lacks corresponding unit test coverage beyond ckxpress, leaving a moderate risk of regression without an added test case.
1 open issue
What changed in this PR
This pull request adds bookmatter as an approved publisher storefront subdomain label so bookmatter.<apex> is treated as an allowed/recognized publisher host, alongside the existing allowlisted publishers.
Changes:
- Add
bookmatterto the approved publisher subdomain allowlist. - Clarify via comment that upstream handle resolution may allow renamed handles (not strictly Liker IDs).
| File | Summary |
|---|---|
shared/constants/publisher-subdomain.ts |
Extends the approved publisher subdomain allowlist to include bookmatter and updates/clarifies inline documentation about IDs vs handles. |
Review effort: Balanced
| // leading/trailing `-`, none of which are legal DNS labels. | ||
| export const PUBLISHER_SUBDOMAIN_LIKER_IDS: readonly string[] = ['ckxpress'] | ||
| // A renamed handle works as well, since the API resolves handles like Liker IDs. | ||
| export const PUBLISHER_SUBDOMAIN_LIKER_IDS: readonly string[] = ['ckxpress', 'bookmatter'] |
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a straightforward allowlist update accompanied by expanded parameterized unit tests that validate getPublisherSubdomainHost() for every approved publisher subdomain label, with no outstanding issues noted in the review evidence.
1 open issue
Review effort: Balanced
No description provided.