Skip to content

[TAS-6934] ✨ Add publisher from to subdomain book links - #1708

Merged
nwingt merged 1 commit into
likecoin:developfrom
nwingt:tas-6934
Nov 5, 2026
Merged

nwingt merged 1 commit into
likecoin:developfrom
nwingt:tas-6934

Conversation

@nwingt

@nwingt nwingt commented Nov 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@nwingt
nwingt requested a balanced review from Copilot November 5, 2026 06:21
@notion-workspace

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

🟢 Approval recommended

The change is narrowly scoped with unit tests covering the new from query propagation across contexts while preserving existing tag behavior and explicit from, and no unresolved issues are noted in the review evidence.

No open issues 🎉

What changed in this PR

Adds consistent publisher attribution when navigating from a publisher subdomain storefront to apex-domain book pages by appending a from=@{publisher} query parameter to outbound book links (without overriding an explicitly provided from), while preserving existing tag propagation and covering the behavior with unit tests.

Changes:

  • Update BookstoreItem route/query construction to add from=@{publisher} on publisher subdomains (preserving explicit from when present).
  • Preserve existing tag query propagation alongside the new from logic.
  • Add unit tests validating from tagging behavior across publisher-subdomain vs apex contexts.
File Summary
app/​components/​BookstoreItem.vue Builds product/staking link routes with from on publisher subdomains while preserving explicit from and keeping tag propagation.
test/​unit/​bookstore-item.test.ts Adds coverage for from/tag behavior across contexts; minor nit: stub useLocaleRoute() to avoid coupling the test to i18n/router internals.

This pull request is ready to be approved.

Review effort: Balanced

@nwingt
nwingt merged commit 05b7f7c into likecoin:develop Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants