Repository navigation
[TAS-6934] ✨ Add publisher from to subdomain book links - #1708
Conversation
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is narrowly scoped with unit tests covering the new from query propagation across contexts while preserving existing tag behavior and explicit from, and no unresolved issues are noted in the review evidence.
No open issues 🎉
What changed in this PR
Adds consistent publisher attribution when navigating from a publisher subdomain storefront to apex-domain book pages by appending a from=@{publisher} query parameter to outbound book links (without overriding an explicitly provided from), while preserving existing tag propagation and covering the behavior with unit tests.
Changes:
- Update
BookstoreItemroute/query construction to addfrom=@{publisher}on publisher subdomains (preserving explicitfromwhen present). - Preserve existing
tagquery propagation alongside the newfromlogic. - Add unit tests validating
fromtagging behavior across publisher-subdomain vs apex contexts.
| File | Summary |
|---|---|
| app/components/BookstoreItem.vue | Builds product/staking link routes with from on publisher subdomains while preserving explicit from and keeping tag propagation. |
| test/unit/bookstore-item.test.ts | Adds coverage for from/tag behavior across contexts; minor nit: stub useLocaleRoute() to avoid coupling the test to i18n/router internals. |
This pull request is ready to be approved.
Review effort: Balanced
No description provided.