You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
A same-tick guard deactivation and reader unmount can skip releasing native volume keys, leaving the shell in paging mode; cleanup must release supported keys and include a regression test.
Release native volume keys when unmounting during capture deactivation
app/composables/use-volume-key-paging.ts:41
If a capture guard becomes false and the reader unmounts in the same tick, this condition skips releasing the native volume keys. The queued watcher is stopped during unmount before it sends enabled: false, so the shell can remain in paging mode after the reader is gone. Release whenever the capability is supported, and add a regression test that deactivates and unmounts without awaiting nextTick().
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The inspected 3ook-com-app lacks volumeKeyPaging support, so the paging contract and hardware-key release behavior on iOS and Android require validation with the companion native build.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The inspected native shell lacks the required bridge support, so protocol compatibility, hardware-key capture/release, and volume restoration require validation on supporting iOS/Android builds and real devices.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Native-device validation is needed for hardware-volume interception and restoration across reader, TTS, and navigation transitions because unit tests simulate bridge messages rather than exercise Android key handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.