Skip to content

[TAS-6959] ✨ Turn reader pages with app volume keys - #1710

Merged
nwingt merged 8 commits into
likecoin:developfrom
nwingt:tas-6959
Nov 11, 2026
Merged

nwingt merged 8 commits into
likecoin:developfrom
nwingt:tas-6959

Conversation

@nwingt

@nwingt nwingt commented Nov 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@notion-workspace

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Volume-key paging lets reading-time tracking stop after two minutes of continued use, and the EPUB and PDF volume-key switches lack accessible names.

2 open issues

Review effort: Balanced

Comment thread app/pages/reader/epub.vue Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A same-tick guard deactivation and reader unmount can skip releasing native volume keys, leaving the shell in paging mode; cleanup must release supported keys and include a regression test.

2 open issues
1 previously missed issue

In code that hasn't changed since last review

Medium severity Release native volume keys when unmounting during capture deactivation

app/​composables/​use-volume-key-paging.ts:41

If a capture guard becomes false and the reader unmounts in the same tick, this condition skips releasing the native volume keys. The queued watcher is stopped during unmount before it sends enabled: false, so the shell can remain in paging mode after the reader is gone. Release whenever the capability is supported, and add a regression test that deactivates and unmounts without awaiting nextTick().

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The inspected 3ook-com-app lacks volumeKeyPaging support, so the paging contract and hardware-key release behavior on iOS and Android require validation with the companion native build.

1 open issue
1 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The inspected native shell lacks the required bridge support, so protocol compatibility, hardware-key capture/release, and volume restoration require validation on supporting iOS/Android builds and real devices.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require resolution for the volume-key page-turning change.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native-device validation is needed for hardware-volume interception and restoration across reader, TTS, and navigation transitions because unit tests simulate bridge messages rather than exercise Android key handling.

No open issues 🎉

Review effort: Balanced

@nwingt
nwingt merged commit a65e714 into likecoin:develop Nov 11, 2026
1 check passed
@nwingt
nwingt deleted the tas-6959 branch November 11, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants